29/Remove token #56
Merged
29/Remove token #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carletex
reviewed
Sep 27, 2021
| @@ -7,9 +7,15 @@ const bodyParser = require("body-parser"); | |||
| // Firebase set up | |||
| const firebaseAdmin = require("firebase-admin"); | |||
| const firebaseServiceAccount = require("./firebaseServiceAccountKey.json"); | |||
| const { userOnly, adminOnly } = require("./middlewares/auth"); | |||
| const { withAddress } = require("./middlewares/auth"); | |||
There was a problem hiding this comment.
Another idea for this middleware name: withProviderAddress
There was a problem hiding this comment.
Provider sounds a bit too ambiguous to me. What about withConnectedAddress or withWalletAddress?
There was a problem hiding this comment.
Proposed «provider» since it's how it's called on the frontend (userProvider, injectedProvider, localProvider). But I like withConnectedAddress also.
carletex
reviewed
Sep 27, 2021
|
|
||
| req.address = addressToken; | ||
| req.isAdmin = tokenContents.claims.isAdmin; | ||
| const withAddress = (req, res, next) => { |
There was a problem hiding this comment.
Maybe we want to return a 401 (or other error status code) if the address is not present?
There was a problem hiding this comment.
yes, makes sense. We can tackle the two comments on the open PR #55
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29
As stated in #29:
Opening the PR against the branch for #46 because that branch will need these changes.
I left a dummy middleware alerting that admins are not checked anymore. That should be solved in #51.