Fix s3 integration error handling #15180
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default behaviour for handling integration errors is to throw the error and have koa relay it as a
400
.If an error object thrown by an integration contains a
statusCode
, koa will ignore the400
and use that instead.In development, if you encountered a permission restriction with your S3 integration, the AWS client would return a
403
and log you out. In prod, the page you were on would reload and you would lose the error message.All errors in the S3 integration throw a new instance of
Error
with any relevant messaging. This will then be relayed with the default400
status.Addresses
Launchcontrol
S3 integration error handling updated