Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix s3 integration error handling #15180

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

deanhannigan
Copy link
Contributor

Description

The default behaviour for handling integration errors is to throw the error and have koa relay it as a 400.
If an error object thrown by an integration contains a statusCode, koa will ignore the 400 and use that instead.

In development, if you encountered a permission restriction with your S3 integration, the AWS client would return a 403 and log you out. In prod, the page you were on would reload and you would lose the error message.

All errors in the S3 integration throw a new instance of Error with any relevant messaging. This will then be relayed with the default 400 status.

Addresses

Launchcontrol

S3 integration error handling updated

@deanhannigan deanhannigan requested a review from a team as a code owner December 13, 2024 12:22
@deanhannigan deanhannigan requested review from mike12345567 and removed request for a team December 13, 2024 12:22
Copy link

qa-wolf bot commented Dec 13, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will let someone from firestorm review too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants