Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows headed mode import #97

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Fix Windows headed mode import #97

merged 1 commit into from
Jul 26, 2023

Conversation

bearfriend
Copy link
Contributor

@bearfriend bearfriend commented Jul 25, 2023

The pausePath is for an import path, not a filesystem path, so always use POSIX-style forward slash. Also, remove leading /C:.

Using an absolute path to the file works because the dev server will resolve and transform it as appropriate for the OS.

@bearfriend bearfriend requested a review from a team as a code owner July 25, 2023 16:55
Copy link
Contributor

@svanherk svanherk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's alive!!!

@bearfriend bearfriend merged commit 0ec21ba into main Jul 26, 2023
1 check passed
@bearfriend bearfriend deleted the windows-pause branch July 26, 2023 15:21
@ghost
Copy link

ghost commented Jul 26, 2023

🎉 This PR is included in version 0.21.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants