use query-string to drive page.js #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
commented
Jul 10, 2023
| @@ -80,7 +80,6 @@ class App extends LitElement { | |||
| this._fullMode = FULL_MODE.GOLDEN.value; | |||
| this._layout = LAYOUTS.SPLIT.value; | |||
| this._overlay = true; | |||
| this._updateFiles(); | |||
There was a problem hiding this comment.
This isn't needed since Page.js's init code will call this.
| } | ||
| _handleSettingChange(e) { | ||
| this[`_${e.detail.name}`] = e.detail.value; | ||
| } | ||
| _handleTestClick(e) { | ||
| this._updateSearchParams({ file: e.target.dataset.file, test: e.target.dataset.test }); | ||
| return false; |
There was a problem hiding this comment.
Returning false from a click handler cases the href to not navigate. The href is still useful for opening links in new tabs.
| } | ||
| }); | ||
| if (tests.length > 0) { | ||
| files.push({ ...f, tests }); | ||
| } | ||
| }); | ||
|
|
||
| if (this._filterTest !== undefined && !foundFilterTest) { |
There was a problem hiding this comment.
This handles the case where you're viewing a particular test but then apply a filter that will cause that test to be excluded. We zoom back out to app home.
bearfriend
approved these changes
Jul 10, 2023
dlockhart
commented
Jul 10, 2023
| } else { | ||
| return this._filterBrowsers.includes(b); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Minor tweak here to use the original browser list to rebuild the filter so that browsers are always rendered in the same order.
|
🎉 This PR is included in version 0.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't quite using the combination of Lit + Page.js + the query-string correctly. This fixes things up.
Essentially:
_testswhich is the actual Lit reactive property that renders the applicationThe end result is that all the filters are on the URL which means you can send people links and the app will "boot up" in the correct state. You can also open the links to individual tests in new tabs and that'll just work as well.