allow filtering on pass/fail and browser #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
force-pushed
the
dlockhart/filtering
branch
from
d58ed1e
to
9f18f79
Compare
dlockhart
force-pushed
the
dlockhart/filtering
branch
from
9f18f79
to
ff0b1d5
Compare
dlockhart
commented
Jul 6, 2023
| position: sticky; | ||
| top: 0; | ||
| z-index: 10; | ||
| } |
There was a problem hiding this comment.
I stole most of these styles from the Daylight Site. They work for now and we can tweak them later!
| `]; | ||
| constructor() { | ||
| super(); | ||
| this._filterBrowsers = data.browsers.map(b => b.name); | ||
| this._filterStatus = data.numFailed > 0 ? FILTER_STATUS.FAILED : FILTER_STATUS.ALL; |
There was a problem hiding this comment.
Default to showing only failed tests, assuming there are any.
src/server/report/test-result.js
Outdated
There was a problem hiding this comment.
This fixes a bug Stacey noticed where the images always grow to fill the viewport. Now they'll fill the viewport but not exceed the actual size of the screenshots.
| @@ -52,7 +63,6 @@ function flattenResults(session, browserData, fileData) { | |||
| const testData = fileData.tests.get(testName); | |||
| if (!t.passed) { | |||
| browserData.numFailed++; | |||
| fileData.numFailed++; | |||
There was a problem hiding this comment.
Counting it here caused it to think that a test failed 3 times if it failed in all 3 browsers, which isn't quite what I want to surface.
Co-authored-by: Stacey Van Herk <[email protected]>
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a fixed sidebar that contains filters for "status" and "browser". Still just basic styling, but starting to add a bit of colour!