Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reporter #502

Merged
merged 4 commits into from
Sep 23, 2024
Merged

fix reporter #502

merged 4 commits into from
Sep 23, 2024

Conversation

dlockhart
Copy link
Member

@dlockhart dlockhart commented Sep 23, 2024

A regression was introduced with the new byte-diff stuff where it's assuming that if a test fails that info will always get set. That's not true if the test fails because it threw an exception, so this code needs to be more resilient.

@dlockhart dlockhart changed the title remove a test fix reporter Sep 23, 2024
@dlockhart dlockhart marked this pull request as ready for review September 23, 2024 17:11
@dlockhart dlockhart requested a review from a team as a code owner September 23, 2024 17:11
@dlockhart dlockhart merged commit a416951 into main Sep 23, 2024
3 checks passed
@dlockhart dlockhart deleted the dlockhart/fix-reporter branch September 23, 2024 17:39
Copy link

🎉 This PR is included in version 1.24.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants