feat: update test reporting default (QE-251) #445
Conversation
Enable test reporting by default when `GITHUB_ACTIONS` environment variable defined
| @@ -215,8 +217,6 @@ export class WTRConfig { | |||
| }); | |||
| } | |||
|
|
|||
| testReporting = !!testReporting || this.#cliArgs['test-reporting']; | |||
There was a problem hiding this comment.
What's the end result going to be for a random repo that didn't previously have this configured? Like there'll now be a JSON file that gets generated when the tests run? Are we worried that it won't be in .gitignore?
There was a problem hiding this comment.
Yeah there will be a d2l-test-report.json generated. I don't think it will be a problem for repos. Most repos don't explicitly check in generated files or do anything after running tests.
There was a problem hiding this comment.
I could add a disable test reporting CLI command if we think we will need to disable it.
There was a problem hiding this comment.
Ok cool. I don't think it's worth adding a flag until we know we'll need it.
devpow112
changed the title
|
🎉 This PR is included in version 1.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
devpow112
changed the title
https://desire2learn.atlassian.net/browse/QE-251
Enable test reporting by default when
GITHUB_ACTIONSenvironment variable defined