Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add in d2l-test-reporting custom reporter and option (QE-251) #437

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

devpow112
Copy link
Contributor

@devpow112 devpow112 commented Jul 15, 2024

Preliminary work for adding in the d2l-test-reporting custom reporter to be able to output our custom format for test meta-data. You can enable test reporting by either adding testReporting: true to your d2l-test-runner.config.js or using a CLI option d2l-test-runner axe --chrome --test-reporting.

Tested this out with core and it seemed to work as expected. It generated a report per test run for the various types of tests.

https://desire2learn.atlassian.net/browse/QE-251

@devpow112 devpow112 added the enhancement New feature or request label Jul 15, 2024
@devpow112 devpow112 force-pushed the depowell/test-reporting branch 2 times, most recently from ae4a58a to 675003a Compare July 15, 2024 18:26
@devpow112

This comment was marked as resolved.

@devpow112 devpow112 force-pushed the depowell/test-reporting branch 4 times, most recently from 488c75f to e1779b2 Compare July 15, 2024 20:39
@devpow112 devpow112 marked this pull request as ready for review July 16, 2024 13:59
@devpow112 devpow112 requested a review from a team as a code owner July 16, 2024 13:59
@devpow112 devpow112 changed the title Add in d2l-test-reporting custom reporter and option [WIP] Add in d2l-test-reporting custom reporter and option Jul 16, 2024
defaultOption: false,
description: 'Enables generating a D2L Test Reporting format JSON file',
order: 14
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to just always enable reporting and either not make it an option, or enable it by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of this but wanted to try out a couple of integrations first. Then we can have it default to always generate.

@devpow112 devpow112 changed the title Add in d2l-test-reporting custom reporter and option feat: add in d2l-test-reporting custom reporter and option Jul 16, 2024
@devpow112 devpow112 requested a review from a team July 16, 2024 20:19
@devpow112 devpow112 merged commit df9d3eb into main Jul 16, 2024
3 checks passed
@devpow112 devpow112 deleted the depowell/test-reporting branch July 16, 2024 20:20
Copy link

🎉 This PR is included in version 1.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bearfriend
Copy link
Contributor

I somehow missed all this. Exciting! 🎉

@devpow112 devpow112 changed the title feat: add in d2l-test-reporting custom reporter and option feat: add in d2l-test-reporting custom reporter and option (QE-251) Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants