Recreate golden with this before each test #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
reviewed
Jun 26, 2023
src/browser/vdiff.js
Outdated
| beforeEach() { | ||
| const { currentTest } = this; | ||
| chai.Assertion.addMethod('golden', function(...args) { | ||
| return ScreenshotAndCompare.call({ test: currentTest, elem: this._obj }, ...args); // eslint-disable-line no-invalid-this |
There was a problem hiding this comment.
I guess this._obj is a Chai thing eh, like it's whatever you call expect(thing).to.be.whatever with?
|
🎉 This PR is included in version 0.12.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
beforeEachroot hook to mocha, in which thegoldenassertion method is recreated to callScreenshotAndComparewith the current test and fixture element inthis.Avoids needing to pass
thistogolden(), which also allows arrow functions to be used.