-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
US152271 - Cleanup appropriate folders in the plugin during runs #36
Conversation
src/server/visual-diff-plugin.js
Outdated
const goldenFileName = `${join(rootDir, '.vdiff', testPath, 'golden', browser, dir, newName)}.png`; | ||
const passFileName = `${join(rootDir, '.vdiff', testPath, 'pass', browser, dir, newName)}.png`; | ||
const screenshotFileName = `${join(rootDir, '.vdiff', testPath, 'fail', browser, dir, newName)}.png`; | ||
const newPath = join(rootDir, '.vdiff', testPath, dir); | ||
const goldenFileName = `${join(newPath, 'golden', browser, newName)}.png`; | ||
const passFileName = `${join(newPath, 'pass', browser, newName)}.png`; | ||
const screenshotFileName = `${join(newPath, 'fail', browser, newName)}.png`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This switches to the new directory structure we settled on in slack
|
||
const isCI = !!env['CI']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this to make CI as quick as possible, but we could leave it out if we'd rather keep things simple. It'll just search for fail
, pass
, and reports
that won't exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this one feels better somehow... like the code responsible for creating the mess is also cleaning it up. Except that the reporter makes the report.html
files.
And I think we'll need some kind of info manager to pass things between the plugin and the reporter for that, and that manager can own the name for |
Co-authored-by: Dave Lockhart <[email protected]>
…spaceUI/testing into US152271_Cleanup_Folders_Option_2
🎉 This PR is included in version 0.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Option 2 - alternative to #32.
After using both I prefer this one - the things that get cleared "make sense" and feel intuitive, whereas the other solution has some compromises.