US157225 - Handle when styles are placed on the host that we want included in the rect #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
approved these changes
Sep 5, 2023
|
In #159, I said:
Basically with this change, we no longer need to set it on the |
|
🎉 This PR is included in version 0.32.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I could get away without this (basically either you use
vdiff-targetfor everything you need in your shadow DOM, or for nothing and the whole element will be used). But then I immediately ran into a problem withd2l-count-badge-icon, which adds a bunch of padding to thehost. So we now always consider the custom element size in therectcalculation.