Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating vdiff goldens for PR 159 #160

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 5, 2023

This pull request updates the vdiff goldens for the changes in pull request #159.

Please review the resulting report closely before merging to ensure the visual differences are expected.

@svanherk
Copy link
Contributor

svanherk commented Sep 5, 2023

This is what I expected

@svanherk svanherk marked this pull request as ready for review September 5, 2023 14:43
@svanherk svanherk requested a review from a team as a code owner September 5, 2023 14:43
@svanherk svanherk merged commit b11eeb7 into US157225_Enhance_rect_calculations Sep 5, 2023
@svanherk svanherk deleted the ghworkflow/vdiff-pr-159 branch September 5, 2023 14:43
svanherk added a commit that referenced this pull request Sep 5, 2023
* Handle multiple vdiff-targets and add vdiff-include functionality

* Add test for multiple inner targets, and add test for vdiff-include

* Temporarily force golden run

* Updating vdiff goldens (#160)

Co-authored-by: github-actions <[email protected]>

* Put proper testing back

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant