Move visual-diff-plugin to testing repo #16
Conversation
bearfriend
force-pushed
the
dgleckler/vdiff-plugin
branch
from
25b7c80
to
4b4bdb1
Compare
| const goldenFileName = `${join(dirname(session.testFile), 'screenshots', ciDir, 'golden', browser, dir, newName)}.png`; | ||
| const currentFileName = `${join(dirname(session.testFile), 'screenshots', ciDir, 'current', browser, dir, newName)}.png`; |
There was a problem hiding this comment.
Doesn't need to be figured out now, but based on the crazy names we've seen in the past hitting Windows limits, wondering if we want to make this shorter. I'm not particularly attached to screenshots
There was a problem hiding this comment.
That's a good point -- could be vdiff?
There was a problem hiding this comment.
Yeah that's what I was thinking, although we're already being a bit inconsistent with when we use vdiff and when we use visual-diff. Maybe we try to keep all consumer facing pieces vdiff, like the group name, this folder, etc? Or do we just change everything to vdiff (like this plugin name)?
There was a problem hiding this comment.
I'm good with being consistent everywhere with vdiff.
There was a problem hiding this comment.
Merging as-is for now, and will address this probably in the golden migration PR.
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Copied from BrightspaceUI/core#3610