Use documentLocaleSettings #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearfriend
force-pushed
the
dgleckler/documentLocaleSettings
branch
from
524b84c
to
81b18dc
Compare
bearfriend
force-pushed
the
dgleckler/documentLocaleSettings
branch
from
56fd48c
to
9ecc8f2
Compare
bearfriend
commented
Sep 1, 2023
Comment on lines
+63
to
+65
| opts.lang ??= ''; | ||
| if (documentLocaleSettings.lamguage !== opts.lang) { | ||
| document.documentElement.lang = opts.lang; |
There was a problem hiding this comment.
- Avoids coercion of nullish values to strings (i.e.
<html lang="null" ...>) - Compares against
documentLocaleSettingsfor guaranteed latest change - Sets
document.documentElement.langto guarantee all values are in sync (documentLocaleSettingsis observing this value)
|
🎉 This PR is included in version 0.31.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
svanherk
reviewed
Sep 1, 2023
| @@ -36,8 +36,9 @@ | |||
| "access": "public" | |||
| }, | |||
| "dependencies": { | |||
| "@rollup/plugin-node-resolve": "^15", | |||
| "@brightspace-ui/intl": "^3", | |||
There was a problem hiding this comment.
Does this mean we can't use @brightspace-ui/testing in intl, or would that still work? 🤔 Looks like we use mocha directly anyways so maybe doesn't matter
There was a problem hiding this comment.
Yeah I think that's what it implies. I'm OK with that, since yeah keeping intl bare bones seems like a good call anyway given how low-level it is.
svanherk
reviewed
Sep 5, 2023
| document.documentElement.setAttribute('lang', opts.lang); | ||
| currentLang = opts.lang; | ||
| opts.lang ??= ''; | ||
| if (documentLocaleSettings.lamguage !== opts.lang) { |
There was a problem hiding this comment.
I assume this should be "language" and this is working right now because this is always true?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of things are listening for changes to the common
DocumentLocaleSettingsinstance, so use that instead of localcurrentLang, which can get out of sync of the lang is changed before the nextreset.d2l-localize-behaviorblew up in all kinds of weird ways when I switched to the newfixturewithout this.