Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow falsy reset options #153

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Allow falsy reset options #153

merged 3 commits into from
Aug 30, 2023

Conversation

bearfriend
Copy link
Contributor

This allows consumers to pass falsy reset options but still fall back to default values when the keys are missing. Also prevents mutating the original options object.

@bearfriend bearfriend requested a review from a team as a code owner August 29, 2023 16:01
Copy link
Member

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, much cleaner!

@bearfriend bearfriend merged commit a1259d1 into main Aug 30, 2023
2 checks passed
@bearfriend bearfriend deleted the dgleckler/reset-defaults branch August 30, 2023 16:49
@ghost
Copy link

ghost commented Aug 30, 2023

🎉 This PR is included in version 0.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants