feat: support configuring mathjax context #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devpow112 I see you spotted this -- interested in your thoughts too! |
grant-cleary
approved these changes
Jul 31, 2023
dbatiste
approved these changes
Jul 31, 2023
I'm definitely happy to make anything simpler. The script was definitely just a workaround (mainly for rubrics/outcomes) when doing test/vdiff stuff (vdiff didn't seem to like me just setting the mathjax context in the HTML directly). Having it be part of the framework makes me happy 😄 |
devpow112
approved these changes
Jul 31, 2023
svanherk
approved these changes
Aug 1, 2023
Co-authored-by: Stacey Van Herk <[email protected]>
|
🎉 This PR is included in version 0.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to remove the need for this plugin which includes this script in unit and visual-diff tests.
Consumers will be able to enable LaTeX in their tests by passing
{ mathjax: { renderLatex: true } }as an option tofixture(). That'll get reset in between each test. If required, I'm leaving the door open to more mathjax configuration options.