expose "slow" CLI parameter and pass-through to Mocha #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
commented
Jul 26, 2023
src/server/wtr-config.js
Outdated
| @@ -14,6 +14,7 @@ const BROWSER_MAP = { | |||
| safari: 'webkit', | |||
| webkit: 'webkit' | |||
| }; | |||
| const DEFAULT_VDIFF_SLOW = 500; | |||
There was a problem hiding this comment.
I'm guessing we'll want to tweak this later once we have vdiff running in core and have a better idea of what "slow" means for visual-diff. We may also want different values locally compared to CI.
svanherk
reviewed
Jul 26, 2023
svanherk
approved these changes
Jul 26, 2023
|
🎉 This PR is included in version 0.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocha has a concept of a "slow" threshold that it uses to highlight slow/normal/fast tests in reports. It defaults to 75ms. Tests which run in at most half that value are "fast", tests which take longer than that value are "slow" and everything else is "normal".
This exposes
slowas a CLI argument tod2l-test-runnerand passes it through to Mocha (similar totimeout). It also sets a default value for vdiff tests of500ms.