Code review refactors

BrightspaceUI · Jun 22, 2023 · 7f5c520 · 7f5c520
1 parent baecb3b
commit 7f5c520
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/server/visual-diff-plugin.js b/src/server/visual-diff-plugin.js
@@ -24,9 +24,11 @@ async function clearDir(updateGoldens, path) {
 	if (updateGoldens) {
 		await rm(path, { force: true, recursive: true });
 	} else {
-		await rm(join(path, PATHS.FAIL), { force: true, recursive: true });
-		await rm(join(path, PATHS.PASS), { force: true, recursive: true });
-		await rm(join(path, 'report.html'), { force: true });
+		await Promise.all([
+			rm(join(path, PATHS.FAIL), { force: true, recursive: true }),
+			rm(join(path, PATHS.PASS), { force: true, recursive: true }),
+			rm(join(path, 'report.html'), { force: true })
+		]);
 	}
 }
 

diff --git a/src/server/wtr-config.js b/src/server/wtr-config.js
@@ -188,7 +188,7 @@ export class WTRConfig {
 			//config.reporters.push(visualDiffReporter());
 
 			config.plugins ??= [];
-			config.plugins.push(visualDiff({ updateGoldens: golden, runSubset: filter?.length > 0 || grep?.length > 0 }));
+			config.plugins.push(visualDiff({ updateGoldens: golden, runSubset: !!(filter || grep) }));
 
 			config.groups.push(this.visualDiffGroup);
 		}