Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "feat: button toggle: Allow consumer to control pressed state" #5150

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

margaree
Copy link
Contributor

@margaree margaree commented Nov 12, 2024

Reverts #5143

Reverting for two reasons:

  1. This is causing double click event handler triggering in the LMS in Toggle
  2. This can actually just be done with an LMS change (adding an e.stopPropagation) so I'll be doing that instead.

If this seems like a pattern others end up needing and are unsure how to implement then we can document it.

@margaree margaree requested a review from a team as a code owner November 12, 2024 18:40
Copy link
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-5150/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

@margaree margaree merged commit 37653e2 into main Nov 12, 2024
6 checks passed
@margaree margaree deleted the revert-5143-button-toggle-consumer-handle-pressed branch November 12, 2024 19:07
Copy link

🎉 This PR is included in version 3.66.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants