Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showYearAndMonth method to d2l-calendar. #5019

Closed
wants to merge 5 commits into from

Conversation

dbatiste
Copy link
Contributor

@dbatiste dbatiste commented Sep 27, 2024

GAUD-6912

This PR adds a new showYearAndMonth(year, month) method to d2l-calendar. This method is a programmatic way to change the year and month like if the user clicked next/previous month buttons. This will be needed by Calendar MVC tool when using the iterator buttons in "Month" view.

@dbatiste dbatiste requested a review from a team as a code owner September 27, 2024 15:51
Copy link
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-5019/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

@dbatiste
Copy link
Contributor Author

Apologies. I've got this working in MVC but it feels super hacky since I'm jumping through hoops to avoid infinite loop. I'm going to put up a new PR for a different approach - what I really want is a property to control the initial year/month in view if provided.

@dbatiste dbatiste closed this Sep 27, 2024
@dbatiste dbatiste deleted the dbatiste/calendar-set-year-month branch September 27, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants