Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC for linear list item #5009

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

POC for linear list item #5009

wants to merge 5 commits into from

Conversation

bearfriend
Copy link
Contributor

@bearfriend bearfriend commented Sep 26, 2024

We recently had a discussion about basic list items appearing out of alignment.

This is a POC for a linear mode for list items to force them to display on a single, center-aligned line with no stacked content and no line wrapping.

Style details are obviously flexible.

Demo at the bottom of list drag and drop page

Bonus fix: The arrow-expand-small icon has bothered me for years:

Screenshot 2024-09-25 at 8 52 57 PM

Before
Screenshot 2024-09-25 at 8 45 19 PM

After
Screenshot 2024-09-25 at 8 45 06 PM

Copy link
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-5009/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

@@ -1,3 +1,3 @@
<svg width="18" height="18" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 18 18" mirror-in-rtl="true">
<svg width="18" height="18" xmlns="http://www.w3.org/2000/svg" viewBox="0 1 18 18" mirror-in-rtl="true">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geurts May want to re-export this with the whole path shifted properly rather than modify the viewbox

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch — here's what I get when I fix the alignment and put it through svgomg:

<svg width="18" height="18" viewBox="0 0 18 18" fill="none" xmlns="http://www.w3.org/2000/svg">
  <path d="M6 12.96v-8c0-.4.2-.8.6-.9.4-.1.8-.1 1.1.2l4 4c.4.4.4 1 0 1.4l-4 4c-.3.3-.7.4-1.1.2-.4-.1-.6-.5-.6-.9Zm2-5.6v3.2l1.6-1.6L8 7.36Z" fill="#494C4E"/>
</svg>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants