feat: Dialog and Dialog-fullscreen: Make title-text required [GAUD-7002] #4999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
|
🎉 This PR is included in version 3.41.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
This overrides the DialogMixin
title-textproperty indialoganddialog-fullscreento make it required.Reasoning: it is an accessibility violation to not have some sort of label on a dialog.
dialog-confirmfalls back totextin the case where there is nottitle-textso it's fine, but these two cases are not.Notes:
title-textand only found one case here (though the GitHub search sometimes misses things so it's possible this will cause an uptick in js errors, in which case we can find these cases and fix them). Let me know if there's any you know of as well.DialogMixinto allow for flexibility (e.g., if they are more like dialog-confirm)