Dialogs: Add axe tests #4991
Merged
Dialogs: Add axe tests #4991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margaree
commented
Sep 19, 2024
| await expect(el).to.be.accessible(); | ||
| }); | ||
|
|
||
| it.skip('no title-text', async() => { |
There was a problem hiding this comment.
We currently list title-text as optional, but it's an axe violation if not present on this and d2l-dialog (d2l-dialog-confirm uses text as backup). I've asked Jeff what he would recommend here.
| await expect(el).to.be.accessible(); | ||
| }); | ||
|
|
||
| it.skip('tall content', async() => { |
There was a problem hiding this comment.
This is the problem we want to address in the defect.
There was a problem hiding this comment.
And presumably this test fails if it isn't skipped?
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
dlockhart
approved these changes
Sep 19, 2024
|
🎉 This PR is included in version 3.40.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of this Jira ticket
Adding axe tests prior to doing the work to make the dialog content container focusable if no focusable elements within it.