US152268 - Bump testing library, causing slight changes in rect size #3967
Conversation
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
|
Co-authored-by: github-actions <[email protected]>
svanherk
dismissed
dlockhart’s stale review
Pushed new changes that should be reviewed
| @@ -739,8 +718,7 @@ describe('d2l-input-number', () => { | |||
| }); | |||
|
|
|||
| it('should handle different locales', async() => { | |||
| documentLocaleSettings.language = 'fr'; | |||
There was a problem hiding this comment.
@bearfriend @dlockhart Changes to the testing library made these tests start failing. I've updated them to set the language through fixture instead (and removed the extra waiting that shouldn't be needed anymore). But let me know if this was testing this method of setting the language specifically, and there's actually an issue in testing.
There was a problem hiding this comment.
Nope this is the perfect change!
| return true; | ||
| }, { interval: 10 }); | ||
| return elem; | ||
| } |
| @@ -739,8 +718,7 @@ describe('d2l-input-number', () => { | |||
| }); | |||
|
|
|||
| it('should handle different locales', async() => { | |||
| documentLocaleSettings.language = 'fr'; | |||
There was a problem hiding this comment.
Nope this is the perfect change!
|
🎉 This PR is included in version 2.143.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
The changes in BrightspaceUI/testing#159 mean that the rect size is calculated slightly differently. Specifically, the rounding here is different than what
page.screenshotwas doing when we gave it fractions of pixels. This will result in some diffs changing size by a couple pixels.Final report: https://vdiff.d2l.dev/BrightspaceUI/core/8253f016c5b2d2b6fdae6baf9cdf430666732bd4/2023-09-05_20-17-12/report/