Migrate button vdiff tests #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
|
dlockhart
reviewed
Aug 30, 2023
dlockhart
reviewed
Aug 30, 2023
svanherk
reviewed
Aug 30, 2023
bearfriend
force-pushed
the
dgleckler/button-vdiff
branch
from
a58785c
to
25b2ac7
Compare
svanherk
reviewed
Aug 30, 2023
Comment on lines
+32
to
+51
| [ | ||
| { category: 'default-icon', template: html`<d2l-button-subtle icon="tier1:bookmark-hollow" text="Subtle Button"></d2l-button-subtle>` }, | ||
| { category: 'default-icon-right', template: html`<d2l-button-subtle icon="tier1:chevron-down" text="Subtle Button" icon-right></d2l-button-subtle>` }, | ||
| { category: 'slim-icon', template: html`<d2l-button-subtle slim icon="tier1:bookmark-hollow" text="Subtle Button"></d2l-button-subtle>` }, | ||
| { category: 'slim-icon-right', template: html`<d2l-button-subtle slim icon="tier1:chevron-down" text="Subtle Button" icon-right></d2l-button-subtle>` } | ||
| ].forEach(({ category, template }) => { | ||
|
|
||
| describe(category, () => { | ||
| [ | ||
| { name: 'normal' }, | ||
| { name: 'rtl', rtl: true } | ||
| ].forEach(({ action, name, rtl }) => { | ||
| it(name, async() => { | ||
| const elem = await fixture(template, { rtl }); | ||
| if (action) await action(elem); | ||
| await expect(elem).to.be.golden(); | ||
| }); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I was getting too confused with all the new tests and wanted to make sure we didn't miss properly renaming any of the old ones. I'd like to merge this like this, and then immediately put up a PR that removes this block and uncomments the tests above, giving a set of net new goldens to judge
Co-authored-by: github-actions <[email protected]>
svanherk
approved these changes
Aug 31, 2023
|
🎉 This PR is included in version 2.142.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TA178549: button and icons
Largely the same as the initial rewrite in #3610 with some minor tweaks
Final Report: https://vdiff.d2l.dev/BrightspaceUI/core/f0a05037a11723c977fe7bc75225ae40b336933b/2023-08-30_22-04-52/report/