Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update filter docs with paging #3833

Merged
merged 3 commits into from
Aug 2, 2023
Merged

fix: update filter docs with paging #3833

merged 3 commits into from
Aug 2, 2023

Conversation

GZolla
Copy link
Contributor

@GZolla GZolla commented Jul 17, 2023

Include a section in the filter documentation to emphasize the expected use of paging and manual search.

Rally: US151801

@github-actions
Copy link
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://pr-3833-brightspace-ui-core.d2l.dev/

Note
The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

Copy link
Contributor

@svanherk svanherk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things below, overall I find this very clear! But I'm probably biased 😄, we'll see what Jeff thinks!

components/filter/README.md Outdated Show resolved Hide resolved
components/filter/README.md Outdated Show resolved Hide resolved
components/filter/README.md Outdated Show resolved Hide resolved
@GZolla GZolla marked this pull request as ready for review August 1, 2023 15:07
@GZolla GZolla requested a review from a team as a code owner August 1, 2023 15:07
@GZolla GZolla merged commit 90548af into main Aug 2, 2023
5 checks passed
@GZolla GZolla deleted the gzolla/filter-docs-paging branch August 2, 2023 15:08
@ghost
Copy link

ghost commented Aug 2, 2023

🎉 This PR is included in version 2.137.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants