Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE53956 Replace optional chaining syntax for compatibility with Polymer #3822

Conversation

mostlyfabulous
Copy link
Contributor

DE53956: [WCAG2.2] Activity Feed > Several buttons with enclosed focus not meeting Focus appearance requirements

We haven't managed to move away from Polymer yet: https://github.com/Brightspace/assignments-ui/pull/323#issuecomment-1631896201

@mostlyfabulous mostlyfabulous requested a review from a team as a code owner July 12, 2023 18:03
@github-actions
Copy link
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://pr-3822-brightspace-ui-core.d2l.dev/

Note
The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

@svanherk
Copy link
Contributor

We've definitely started using optional chaining in a number of places across core, this might not be the only spot that's an issue. It's actually not a Polymer problem, just a polymer-cli problem because it's so old and not updated/maintained. Is it only polymer lint that's failing for you? Or does the polymer test command fail too?

@dlockhart
Copy link
Member

Yeah recently when we've been running into this, we've started switching repos off polymer lint entirely and converting polymer test uses over to the more modern @web/test-runner. You're going to run into a lot more than core using modern JS these days.

@mostlyfabulous
Copy link
Contributor Author

It fails on polymer lint. I can't run polymer test locally anymore 😅- getting errors now when I try.
We've got the De-FRA on the backlog, but I'm not sure when we'll fully be able to start on it.

@mostlyfabulous
Copy link
Contributor Author

Would you recommend we just remove polymer lint for now as optional chaining will work otherwise?

@dlockhart
Copy link
Member

Yep, just remove it.

@mostlyfabulous mostlyfabulous deleted the awong/20.23.8/DE5396-replace-optional-chaining-syn branch July 13, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants