Recursively check for last item in nested lists #3798
Conversation
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
|
|
Visual diff tests failed - pull request #3799 has been opened with the updated goldens. |
| } | ||
| return lastItem; |
There was a problem hiding this comment.
This should probably use do...while. I always forget about that.
| } | ||
| return lastItem; |
There was a problem hiding this comment.
Previously, this would have only returned something if the nested list had items -- otherwise it would have fallen out of this block and returned previousElement. I think now if nestedItems initially has nothing in it, lastItem won't get set to anything and the whole thing will return undefined.
|
🎉 This PR is included in version 2.132.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
DE53272: List > Grid navigation not navigating properly to deeply nested list items
When looking for the previous item to focus in grid mode, the last item should be checked recursively for nested lists.