Fix list-item-expand-collapse button positioning #3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
|
dlockhart
approved these changes
Jun 29, 2023
| width: 0; | ||
| } | ||
| :host([dir="rtl"][_render-expand-collapse-slot]) .d2l-list-expand-collapse { | ||
| padding: 0.4rem 0 0 0.3rem; | ||
| padding: 0.55rem 0 0 0.3rem; |
There was a problem hiding this comment.
Really excited to start converting this stuff to logical properties...
There was a problem hiding this comment.
I almost did it but decided not to scope creep.
|
Visual diff tests failed - pull request #3797 has been opened with the updated goldens. |
dbatiste
approved these changes
Jun 29, 2023
Co-authored-by: github-actions <[email protected]>
|
🎉 This PR is included in version 2.132.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.55remmatches various margins inlist-item-mixinlike the checkbox, which is exactly the same size, and will now line up vertically with the expand-collapse button.Before and after:
