Move tag list tests to proper browsers interactions #3791
Conversation
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
|
| const button = elem.shadowRoot.querySelector('d2l-button-subtle.d2l-tag-list-clear-button'); | ||
|
|
||
| setTimeout(() => button.click()); | ||
| clickElem(button); |
There was a problem hiding this comment.
I think we still want to do this kind of thing in a timeout in case the event gets fired synchronously from the click handler.
There was a problem hiding this comment.
I wasn't getting any flake locally without it, and I think it might always be safe to do this without, but it'd be good to know definitively either way before we convert/write more of these. I'll look into it.
There was a problem hiding this comment.
Also, if it's not safe, maybe we wrap them so it is always safe?
There was a problem hiding this comment.
Yeah maybe it makes sense for us to put the setTimeout inside all of these utilities eh? The Promises they return can still resolve after the action has complete if that's what they're going for, but if you don't care you can just call it and then await an event on the next line.
There was a problem hiding this comment.
Looked into this and discussed offline. There are multiple steps in other processes that make these interactions inherently significantly delayed (in the event loop, not actually time) so for now we're thinking these should be safe to run in this order without intervention, but we can always build in a delay later if needed.
|
🎉 This PR is included in version 2.132.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Uses proper browser mouse/keyboard interactions from the testing library instead of javascript methods/events to simulate them.