Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the tag-list-item target-size to be 24x24px. #3779

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

dbatiste
Copy link
Contributor

DE51531

This PR makes two accessibility improvements:

  1. It updates the size of the button to be 24x24px for wcag 2.2, along with tweaking spacing so that it's still evenly positioned.
  2. It moves the whitespace between the text and the clear button to be outside d2l-button-icon instead of inside. Previously with the whitespace rendered inside d2l-button-icon but outside the actual button, it would be possible to invoke the clear action by clicking those pixels even though the hover effect was not activated. With this change, the click target accurately matches the visual hover feedback.

The tag-list-item does get 1px wider as a result. The height remains the same:

Before:
image
image

After:
image
image

@dbatiste dbatiste requested a review from a team as a code owner June 23, 2023 15:47
@github-actions
Copy link
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://pr-3779-brightspace-ui-core.d2l.dev/

Note
The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

@github-actions
Copy link
Contributor

Visual diff tests failed - pull request #3780 has been opened with the updated goldens.

@dbatiste dbatiste merged commit 094f24f into main Jun 23, 2023
5 checks passed
@dbatiste dbatiste deleted the dbatiste/tag-list-item-clear-target-size branch June 23, 2023 17:53
@ghost
Copy link

ghost commented Jun 23, 2023

🎉 This PR is included in version 2.131.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants