fix: update constructor helper #3770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
|
|
Ugh, license checker. |
dlockhart
changed the title
|
Hmm, this is gonna be a mess in BSI I think - maybe we just keep this one place using |
|
Yeah agreed -- already pushed that change, which seems to be the least bad of all the bad options. |
svanherk
approved these changes
Jun 21, 2023
ChrisLabattD2L
approved these changes
Jun 21, 2023
|
🎉 This PR is included in version 2.131.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
bearfriend
pushed a commit
that referenced
this pull request
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChrisLabattD2L noticed that since switching from
@open-wc/testingto@brightspace-ui/testing, repos using the constructor test helper now fail to import@brightspace-ui/testingbecause it's only adevDependency. This would have also been a problem previously, but all repos using it must have also depended on@open-wc/testing.Longer term, I think this helper should just move over to
@brightspace-ui/testing, but that will require switching all consumers over to it... of which there are >450.