remove retries #3769
Merged
remove retries #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
|
dbatiste
approved these changes
Jun 21, 2023
|
Interestingly this didn't affect the time it took in CI to run the tests at all, which likely means they're always single-threaded... which doesn't bode well for our visual-diff tests being faster. |
|
🎉 This PR is included in version 2.131.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
That's definitely worrisome 😟 |
bearfriend
pushed a commit
that referenced
this pull request
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing these retries now that we've uncovered the source of the problem -- that Firefox + Playwright in a multithreaded environment causes focus to be randomly lost. The testing library has been updated such that Firefox always runs single-threaded.