US134384 - Add new subscription controllers #1927
Conversation
| super.updated(changedProperties); | ||
| if (this._subscriptionController) this._subscriptionController.hostUpdated(changedProperties); | ||
| } | ||
| ``` |
There was a problem hiding this comment.
I found the sample code a little hard to follow in terms of tying what the example was trying to do to the core concepts. 🐶 🐱 It's very cute though and I did learn fun facts about tongue prints!
Maybe a metaphor that also uses a subscription pattern could work? Like a "newspaper" <-> "reader" or a "cable company" <-> "viewer" type metaphor? Do people still even subscribe to newspapers?!
There was a problem hiding this comment.
Yeah I adapted this from the Provider/Requester README, but using a more intuitive subscription example makes sense. I'll try it with cable channels and viewers
There was a problem hiding this comment.
Ok, updated - let me know if that works better. It's still a bit of a weird example when looking at the resulting html, but I wanted to show how event subscribers must go inside the registry component, and id subscribers can go outside.
…rray instead of using a type converter
|
🎉 This PR is included in version 1.212.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Cleaned up version of #1901. Creates a new
controllersfolder with new subscriber controllers inside, along with tests and a README. The README was surprisingly difficult to write and I don't love it - feedback welcome