Skip to content

Commit

Permalink
Fix flaky vdiff tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@bearfriend
bearfriend committed Jul 19, 2023
1 parent 3a5f2f6 commit ff00651
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
6 changes: 3 additions & 3 deletions components/button/test/floating-buttons.vdiff.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,19 +43,19 @@ describe('d2l-floating-buttons', () => {
it('does not float at bottom of container', async() => {
const elem = await fixture(floatingButtonsFixture);
window.scrollTo(0, document.body.scrollHeight);
await expect(elem).to.be.golden();
await expect(elem).to.be.golden({ wait: true });
});

it('does not float when small amount of content', async() => {
const elem = await fixture(floatingButtonsShortFixture);
await expect(elem).to.be.golden();
await expect(elem).to.be.golden({ wait: true });
});

it('floats when content added to dom', async() => {
const elem = await fixture(floatingButtonsShortFixture);
const contentElem = document.querySelector('#floating-buttons-short-content').querySelector('p');
contentElem.innerHTML += '<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>I love Coffe<br><br>';
await expect(elem).to.be.golden();
await expect(elem).to.be.golden({ wait: true });
});

it('floats at bottom of page when always-float', async() => {
Expand Down
20 changes: 10 additions & 10 deletions components/list/test/list.vdiff.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,30 +70,30 @@ function createSimpleFixture(separatorType, extendSeparators = false) {
function createExpandCollapseFixture(expanded, selectable, draggable) {
return html`
<d2l-list style="width: 600px;">
<d2l-list-item expandable ?expanded="${expanded}" ?selectable="${selectable}" ?draggable="${draggable}" key="L1-1">
<d2l-list-item expandable ?expanded="${expanded}" ?selectable="${selectable}" ?draggable="${draggable}" key="L1-1" label="L1-1">
<d2l-list-item-content>
<div>Level 1, Item 1</div>
<div slot="supporting-info">Supporting text for top level list item</div>
</d2l-list-item-content>
<d2l-list slot="nested">
<d2l-list-item ?selectable="${selectable}" ?draggable="${draggable}" key="L2-1">
<d2l-list-item ?selectable="${selectable}" ?draggable="${draggable}" key="L2-1" label="L2-1">
<d2l-list-item-content>
<div>Level 2, Item 1</div>
<div slot="supporting-info">Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer enim.</div>
</d2l-list-item-content>
</d2l-list-item>
<d2l-list-item expandable ?expanded="${expanded}" ?selectable="${selectable}" ?draggable="${draggable}" key="L2-2">
<d2l-list-item expandable ?expanded="${expanded}" ?selectable="${selectable}" ?draggable="${draggable}" key="L2-2" label="L2-2">
<d2l-list-item-content>
<div>Level 2, Item 2</div>
<div slot="supporting-info">Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer enim.</div>
</d2l-list-item-content>
<d2l-list slot="nested">
<d2l-list-item ?selectable="${selectable}" ?draggable="${draggable}" key="L3-1">
<d2l-list-item ?selectable="${selectable}" ?draggable="${draggable}" key="L3-1" label="L3-1">
<d2l-list-item-content>
<div>Level 3, Item 1</div>
</d2l-list-item-content>
</d2l-list-item>
<d2l-list-item ?selectable="${selectable}" ?draggable="${draggable}" key="L3-2">
<d2l-list-item ?selectable="${selectable}" ?draggable="${draggable}" key="L3-2" label="L3-2">
<d2l-list-item-content>
<div>Level 3, Item 2</div>
</d2l-list-item-content>
Expand Down Expand Up @@ -807,7 +807,7 @@ describe('d2l-list', () => {
return html`
<d2l-list style="width: 600px;">
<d2l-list-controls slot="controls" no-sticky></d2l-list-controls>
<d2l-list-item selectable key="L1-1">
<d2l-list-item selectable key="L1-1" label="L1-1">
<d2l-list-item-content>
<div>Level 1, Item 1</div>
<div slot="supporting-info">Prow scuttle parrel provost Sail ho shrouds spirits boom mizzenmast yardarm.</div>
Expand All @@ -817,25 +817,25 @@ describe('d2l-list', () => {
<button>action 2</button>
</div>
<d2l-list slot="nested" separators="between">
<d2l-list-item selectable ?selected="${selectedType === 'all'}" key="L2-1">
<d2l-list-item selectable ?selected="${selectedType === 'all'}" key="L2-1" label="L2-1">
<d2l-list-item-content>
<div>Level 2, Item 1</div>
<div slot="supporting-info">Prow scuttle parrel provost Sail ho shrouds spirits boom mizzenmast yardarm. Pinnace holystone mizzenmast quarter crow's nest nipperkin grog yardarm hempen halter furl.</div>
</d2l-list-item-content>
</d2l-list-item>
<d2l-list-item selectable key="L2-2">
<d2l-list-item selectable key="L2-2" label="L2-2">
<d2l-list-item-content>
<div>Level 2, Item 2</div>
<div slot="supporting-info">Prow scuttle parrel provost Sail ho shrouds spirits boom mizzenmast yardarm. Pinnace holystone mizzenmast quarter crow's nest nipperkin grog yardarm hempen halter furl.</div>
</d2l-list-item-content>
<d2l-list slot="nested" separators="between">
<d2l-list-item selectable ?selected="${selectedType === 'all'}" key="L3-1">
<d2l-list-item selectable ?selected="${selectedType === 'all'}" key="L3-1" label="L3-1">
<d2l-list-item-content>
<div>Level 3, Item 1</div>
<div slot="supporting-info">Prow scuttle parrel provost Sail ho shrouds spirits boom mizzenmast yardarm. Pinnace holystone mizzenmast quarter crow's nest nipperkin grog yardarm hempen halter furl.</div>
</d2l-list-item-content>
</d2l-list-item>
<d2l-list-item selectable ?selected="${selectedType === 'all' || selectedType === 'some'}" key="L3-2">
<d2l-list-item selectable ?selected="${selectedType === 'all' || selectedType === 'some'}" key="L3-2" label="L3-2">
<d2l-list-item-content>
<div>Level 3, Item 2</div>
<div slot="supporting-info">Prow scuttle parrel provost Sail ho shrouds spirits boom mizzenmast yardarm. Pinnace holystone mizzenmast quarter crow's nest nipperkin grog yardarm hempen halter furl.</div>
Expand Down

0 comments on commit ff00651

Please sign in to comment.