Add comment and test re not dispatching event initially.

BrightspaceUI · Sep 25, 2024 · 07d4fd1 · 07d4fd1
1 parent 67875d6
commit 07d4fd1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/components/calendar/calendar.js b/components/calendar/calendar.js
@@ -598,6 +598,7 @@ class Calendar extends LocalizeCoreElement(RtlMixin(LitElement)) {
 	willUpdate(changedProperties) {
 		super.willUpdate(changedProperties);
 
+		// don't dispatch d2l-calendar-view-change when _shownYear and _shownMonth are being initialized
 		if (changedProperties.get('_shownYear') === undefined && changedProperties.get('_shownMonth') === undefined) return;
 
 		const dates = getDatesInMonthArray(this._shownMonth, this._shownYear);

diff --git a/components/calendar/test/calendar.test.js b/components/calendar/test/calendar.test.js
@@ -112,6 +112,15 @@ describe('d2l-calendar', () => {
 			expect(detail.maxValue).to.deep.equal(new Date(2015, 9, 31));
 		});
 
+		it('does not dispatch d2l-calendar-view-change event initially', async() => {
+			let dispatched = false;
+			const calendar = document.createElement('d2l-calendar');
+			calendar.addEventListener('d2l-calendar-view-change', () => dispatched = true);
+			document.body.appendChild(calendar);
+			await calendar.updateComplete;
+			expect(dispatched).to.equal(false);
+		});
+
 	});
 
 	describe('focus date', () => {