Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: fix sqf case util when code doesn't end with whitespace #757

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

PabstMirror
Copy link
Collaborator

flush buffer if file ends on a char (no whitespace/newline)

e.g. https://github.com/BourbonWarfare/POTATO/blob/master/addons/bodyCleanup/functions/fnc_getPlayerViewCones.sqf#L48
it would delete the last _viewCones

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.2%. Comparing base (f43d44b) to head (4faf2b6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
bin/src/utils/sqf/case.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
bin/src/utils/sqf/case.rs 7.4% <0.0%> (-0.2%) ⬇️

Copy link
Owner

@BrettMayson BrettMayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah shoot, good catch

@BrettMayson BrettMayson merged commit d7c92a5 into main Sep 2, 2024
26 of 31 checks passed
@BrettMayson BrettMayson deleted the caseUtilEnd branch September 2, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants