Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't silently consume Exceptions when uploading assets #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't silently consume Exceptions when uploading assets #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 32 additions & 37 deletions src/main/groovy/com/github/breadmoirai/githubreleaseplugin/GithubReleaseTask.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,45 +97,40 @@ class GithubReleaseTask extends DefaultTask {

@TaskAction
void publishRelease() {
try {
if (dryRun.get()) {
log "This task is a dry run. All API calls that would modify the repo are disabled. API calls that access the repo information are not disabled. Use this to show what actions would be executed."
}
GithubApi.endpoint = apiEndpoint.get()
final CharSequence authValue = authorization.get()
final GithubApi api = new GithubApi(authValue)
final CharSequence ownerValue = owner.get()
final CharSequence repoValue = repo.get()
final CharSequence tagValue = tagName.get()
log 'CHECKING FOR PREVIOUS RELEASE'
def previousRelease = api.findReleaseByTag ownerValue, repoValue, tagValue
switch (previousRelease.code) {
case 200:
log "EXISTING RELEASE FOUND ${previousRelease.body.html_url}"
if (this.overwrite.get()) {
deleteRelease(api, previousRelease)
createRelease(api, ownerValue, repoValue, tagValue)
} else if (this.allowUploadToExisting.get() && (releaseAssets.size() > 0)) {
log 'UPLOADING ASSETS TO EXISTING RELEASE'
uploadAssetsToUrl api, previousRelease.body.upload_url as String
if (!draft.get()) {
api.patchReleaseAsPublished(previousRelease.body.url as String)
}
} else if (previousRelease.body.draft as Boolean) {
if (dryRun.get()) {
log "This task is a dry run. All API calls that would modify the repo are disabled. API calls that access the repo information are not disabled. Use this to show what actions would be executed."
}
GithubApi.endpoint = apiEndpoint.get()
final CharSequence authValue = authorization.get()
final GithubApi api = new GithubApi(authValue)
final CharSequence ownerValue = owner.get()
final CharSequence repoValue = repo.get()
final CharSequence tagValue = tagName.get()
log 'CHECKING FOR PREVIOUS RELEASE'
def previousRelease = api.findReleaseByTag ownerValue, repoValue, tagValue
switch (previousRelease.code) {
case 200:
log "EXISTING RELEASE FOUND ${previousRelease.body.html_url}"
if (this.overwrite.get()) {
deleteRelease(api, previousRelease)
createRelease(api, ownerValue, repoValue, tagValue)
} else if (this.allowUploadToExisting.get() && (releaseAssets.size() > 0)) {
log 'UPLOADING ASSETS TO EXISTING RELEASE'
uploadAssetsToUrl api, previousRelease.body.upload_url as String
if (!draft.get()) {
api.patchReleaseAsPublished(previousRelease.body.url as String)
} else {
throw new Error(':githubRelease FAILED RELEASE ALREADY EXISTS')
}
break
case 404:
createRelease(api, ownerValue, repoValue, tagValue)
break
default:
throw new Error(":githubRelease FAILED $previousRelease.code $previousRelease.message\n$previousRelease.body")
}
}
catch (Exception e) {
e.printStackTrace()
} else if (previousRelease.body.draft as Boolean) {
api.patchReleaseAsPublished(previousRelease.body.url as String)
} else {
throw new Error(':githubRelease FAILED RELEASE ALREADY EXISTS')
}
break
case 404:
createRelease(api, ownerValue, repoValue, tagValue)
break
default:
throw new Error(":githubRelease FAILED $previousRelease.code $previousRelease.message\n$previousRelease.body")
}
}

Expand Down