Improve part list #519
Merged
Improve part list #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I guess I sucessfully migrated everything to the new list 🥳 As I said, a heavy change, so please test and let me know if you find errors! I realized that we have some minor issues which are not introduced by this PR, but I guess I'll fix them later. |
|
Here's a screenshot, not much visual difference:
But some minor details that I find quite handy:
|
chmorgan
approved these changes
Aug 8, 2024
| @@ -405,91 +409,6 @@ def __init__(self, parent, kicad_provider=KicadProvider()): | |||
| rotation.SetSortable(True) | |||
| side.SetSortable(True) | |||
|
|
|||
There was a problem hiding this comment.
ahh k, could always rebase and fixup the previous change with this one if that makes sense with your git-fu
There was a problem hiding this comment.
No idea what you mean by that 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will replace the ListCtrl used for the main parts list with a DataViewCtrl and a PyDataViewModel.
We will be able to sort the list without having to query the database nd re-populate the list every time.