Refactor LCSC API into seperate class #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmorgan
approved these changes
Jul 31, 2024
|
I've never used squash merge before but now that you pointed it out it is pretty useful 😅 |
gonzalop
pushed a commit
to gonzalop/kicad-jlcpcb-tools
that referenced
this pull request
Jul 31, 2024
* Refactor LCSC API into seperate class * fix icon margin * Fix typo * Make ruff happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the LCSC API can be used in other parts of the code and its a lot cleaner overall.