Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve codebase consistency and bump dependencies #4

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Improve codebase consistency and bump dependencies #4

merged 4 commits into from
Dec 6, 2023

Conversation

letehaha
Copy link
Collaborator

@letehaha letehaha commented Dec 4, 2023 •
edited
Loading

This PR removes code duplication and reuses hooks from the sns-sdk for better consistency.

  1. Reused useDomainSuggestions and useSearch from @bonfida/sns-react
  2. Reused getDomainPriceFromname from @bonfida/spl-name-service
  3. Bump dependencies

@letehaha letehaha added the enhancement New feature or request label Dec 4, 2023
@letehaha letehaha self-assigned this Dec 4, 2023
@letehaha letehaha marked this pull request as ready for review December 5, 2023 16:53
@letehaha letehaha changed the title Reuse hooks from @bonfida/sns-react and bump dependencies Improve codebase consistency and bump dependencies Dec 5, 2023
@dr497 dr497 merged commit 1a29037 into main Dec 6, 2023
2 checks passed
@dr497 dr497 deleted the feat/update-dependencies branch December 6, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr497 dr497 dr497 approved these changes

@akashrdev akashrdev Awaiting requested review from akashrdev

Assignees

@letehaha letehaha

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@letehaha @dr497