Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken search field #32

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Broken search field #32

merged 3 commits into from
Jan 9, 2024

Conversation

letehaha
Copy link
Contributor

@letehaha letehaha commented Jan 8, 2024

Fixes runtime error in both web & Android apps when trying to clear the search field on the search results page

@letehaha letehaha requested a review from dr497 January 8, 2024 14:05
@letehaha letehaha self-assigned this Jan 8, 2024
@letehaha letehaha added the bug Something isn't working label Jan 8, 2024
@dr497
Copy link
Contributor

dr497 commented Jan 8, 2024

Don't we have to run lingui extract?

@letehaha
Copy link
Contributor Author

letehaha commented Jan 8, 2024

@dr497 yes you totally right, thanks! I thought since amount of lines didn't change then we don't need to do it, but I was wrong
I think I'll add the same CI check here that we have for the website

@dr497 dr497 merged commit b254825 into master Jan 9, 2024
4 checks passed
@dr497 dr497 deleted the fix/broken-search-field branch January 9, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants