Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add blockexplorer setting for links and claiming #639

Closed
wants to merge 1 commit into from
Closed

Conversation

dni
Copy link
Contributor

@dni dni commented Jul 15, 2024

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Jul 15, 2024 8:23am
webapp-mainnet ✅ Ready (Inspect) Visit Preview Jul 15, 2024 8:23am

@kilrau
Copy link
Member

kilrau commented Jul 15, 2024

Gave this a quick glance, should work but need to think about how we handle cases like "Liquid Lowball fees not available via external services"

@michael1011
Copy link
Member

but need to think about how we handle cases like "Liquid Lowball fees not available via external services"

You just switch to 0.1 sat/vbyte and only allow switching to a non-lowball endpoint when there are no pending reverse or chain swaps

@kilrau
Copy link
Member

kilrau commented Jul 16, 2024

only allow switching to a non-lowball endpoint when there are no pending reverse or chain swaps

Better allow switching any time but only apply to swaps created after enabling.

So you'd be fine with putting "Alternative endpoints do not feature low Liquid fees and will use the standard 0.1 sat/vbyte" in the ? part and that's it? @michael1011

@michael1011
Copy link
Member

So you'd be fine with putting "Alternative endpoints do not feature low Liquid fees and will use the standard 0.1 sat/vbyte" in the ? part and that's it?

Yes

@kilrau kilrau self-requested a review July 16, 2024 14:36
@kilrau
Copy link
Member

kilrau commented Jul 17, 2024

only allow switching to a non-lowball endpoint when there are no pending reverse or chain swaps

Better allow switching any time but only apply to swaps created after enabling.

So you'd be fine with putting "Alternative endpoints do not feature low Liquid fees and will use the standard 0.1 sat/vbyte" in the ? part and that's it? @michael1011

Ayt let's do it this way then. Fees currently don't update when I choose a non-Boltz "Broadcaster".

The thing I am not happy with yet is the button style. We are abusing a toggle (which is meant to hold 2 very simple states) for a dropdown now. Should be similar style than asset selector. A toggle just doesn't work for writing out longer words, let alone three.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants