Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSK swaps #306

Merged
merged 26 commits into from
Nov 19, 2023
Merged

RSK swaps #306

merged 26 commits into from
Nov 19, 2023

Conversation

michael1011
Copy link
Member

@michael1011 michael1011 commented Nov 15, 2023 •
edited
Loading

Todos:

@vercel Vercel
Copy link

vercel bot commented Nov 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Nov 19, 2023 11:19pm
webapp-mainnet ✅ Ready (Inspect) Visit Preview Nov 19, 2023 11:19pm

@kilrau kilrau self-requested a review November 15, 2023 16:15
@kilrau
Copy link
Member

kilrau commented Nov 15, 2023 •
edited by michael1011
Loading

  • Since it's the only option and only button I can click the Connect Wallet button should be yellow, turn blue and allow Disconnect Wallet.
    image

@kilrau
Copy link
Member

kilrau commented Nov 15, 2023 •
edited by michael1011
Loading

Reverse Swap: worked, nice!!!

  • please add a text Press "Claim" in order to open your connected wallet and confirm the displayed transaction.
  • show a (fake if its has to) "Claiming in progress" with the same 3 dot animation as for the mempool
    Screenshot from 2023-11-15 17-21-58
    Screenshot from 2023-11-15 17-27-06
    Screenshot from 2023-11-15 17-27-40
    Screenshot from 2023-11-15 17-28-00

@kilrau
Copy link
Member

kilrau commented Nov 15, 2023 •
edited by michael1011
Loading

Normal Swap: worked, nice!!!

  • same as above please add a text Press "Send" in order to open your connected wallet and confirm the displayed transaction.
    image
    This also needs a text like "Transaction is in mempool", same as above
    image
    image
    image

@kilrau
Copy link
Member

kilrau commented Nov 15, 2023

Refunds are still missing no?

@michael1011
Copy link
Member Author

Refunds are still missing no?

yes

@dni
remove disconnect button
63c86ca 
and show button with address instead and when click disconnects.
@michael1011 michael1011 marked this pull request as ready for review November 19, 2023 21:26
@michael1011 michael1011 requested a review from dni November 19, 2023 23:01
@michael1011 michael1011 merged commit fa6a6dc into main Nov 19, 2023
4 checks passed
dni
dni approved these changes Nov 19, 2023
View reviewed changes
Copy link
Contributor

@dni dni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HUGE change, LGTM

@michael1011 michael1011 deleted the rsk-swaps branch November 19, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dni dni dni approved these changes

@kilrau kilrau Awaiting requested review from kilrau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael1011 @kilrau @dni