feat: add bip21 addresses for onchain and lightning #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
michael1011
requested changes
Nov 14, 2023
kilrau
requested changes
Nov 16, 2023
|
Reverse swap works, but don't truncate, just leave the whole BIP21 unified string there just like you do for normal swaps. Also make sure that tests cover it all. |
kilrau
requested changes
Nov 17, 2023
There was a problem hiding this comment.
Parsing unified BIP21s (https://bitcoinqr.dev/) for normal swaps works fine.
Reverse swaps still several issues:
liquidnetwork:bip21s are not recognizedbitcoin:with legacy P2PKH (1...) or P2WPKH-nested-in-P2SH (3...) still not recognized as I mentioned in my previous review.
|
waiting for other prs to resolve first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #302