feat: proper amount validation #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael1011
approved these changes
Nov 6, 2024
Comment on lines
+23
to
+27
| CurrencyLiquid: { | ||
| NormalClaim: 1337, | ||
| ReverseLockup: 2503, | ||
| ReverseClaim: 1309, | ||
| }, |
There was a problem hiding this comment.
We'll need to adjust those for CheapCT
jackstar12
force-pushed
the
feat/amount-validation
branch
from
92244f6
to
e1b640d
Compare
michael1011
approved these changes
Nov 7, 2024
jackstar12
added a commit
that referenced
this pull request
Nov 7, 2024
* feat: amountless chain swaps * chore: fix tests * fix: update chain swap amounts in tx * feat: proper amount validation (#330) * feat: proper amount validation * fix: validate submarine swap amounts if invoice is set after lockup * feat: add absolute network fee tolerance * refactor: onchainFees -> networkFees * chore: remove done TODO * fix: make sure to handle 0 amount same as nil for backwards compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.