feat: ListWalletTransactions rpc
#286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackstar12
force-pushed
the
list-wallet-transactions
branch
2 times, most recently
from
768ece6
to
357d4f2
Compare
michael1011
approved these changes
Sep 11, 2024
jackstar12
force-pushed
the
list-wallet-transactions
branch
2 times, most recently
from
534d3b8
to
f72a88c
Compare
jackstar12
force-pushed
the
list-wallet-transactions
branch
from
f72a88c
to
1c74d3b
Compare
michael1011
approved these changes
Sep 16, 2024
| @@ -733,6 +738,49 @@ message GetWalletRequest { | |||
| optional uint64 id = 2; | |||
| } | |||
|
|
|||
| message ListWalletTransactionsRequest { | |||
| uint64 id = 1; | |||
There was a problem hiding this comment.
What does id mean in this context here? It's not clear from just the proto
| string address = 1; | ||
| uint64 amount = 2; | ||
| // wether the address is controlled by the wallet | ||
| bool is_our_address = 3; |
There was a problem hiding this comment.
Suggested change
| bool is_our_address = 3; | |
| bool is_ours = 3; |
| // its the sum of all output values minus the sum of all input values which are controlled by the wallet. | ||
| // positive values indicate incoming transactions, negative values outgoing transactions | ||
| int64 balance_change = 2; | ||
| int64 timestamp = 3; |
There was a problem hiding this comment.
Suggested change
| int64 timestamp = 3; | |
| uint64 timestamp = 3; |
| return nil, err | ||
| } | ||
| for _, tx := range outputs.Transactions { | ||
| if tx.TxId == txId || txId == "" { | ||
| for _, tx := range transactoins { |
There was a problem hiding this comment.
Suggested change
| for _, tx := range transactoins { | |
| for _, tx := range transactions { |
| limit = 30 | ||
| } | ||
| if limit > 30 { | ||
| return nil, errors.New("limit cant be larger than 30") |
There was a problem hiding this comment.
Suggested change
| return nil, errors.New("limit cant be larger than 30") | |
| return nil, errors.New("limit cannot be larger than 30") |
| message WalletTransaction { | ||
| string id = 1; | ||
| // balance change of the wallet in satoshis. | ||
| // its the sum of all output values minus the sum of all input values which are controlled by the wallet. |
There was a problem hiding this comment.
Suggested change
| // its the sum of all output values minus the sum of all input values which are controlled by the wallet. | |
| // It is the sum of all output values minus the sum of all input values which are controlled by the wallet. |
|
|
||
| message WalletTransaction { | ||
| string id = 1; | ||
| // balance change of the wallet in satoshis. |
There was a problem hiding this comment.
Suggested change
| // balance change of the wallet in satoshis. | |
| // Balance change of the wallet in satoshis. |
| string id = 1; | ||
| // balance change of the wallet in satoshis. | ||
| // its the sum of all output values minus the sum of all input values which are controlled by the wallet. | ||
| // positive values indicate incoming transactions, negative values outgoing transactions |
There was a problem hiding this comment.
Suggested change
| // positive values indicate incoming transactions, negative values outgoing transactions | |
| // Positive values indicate incoming transactions, negative values outgoing transactions. |
| int64 timestamp = 3; | ||
| repeated TransactionOutput outputs = 4; | ||
| uint32 block_height = 6; | ||
| // swaps which are related to this transaction |
There was a problem hiding this comment.
Suggested change
| // swaps which are related to this transaction | |
| // Swaps which are related to this transaction. |
| message TransactionOutput { | ||
| string address = 1; | ||
| uint64 amount = 2; | ||
| // wether the address is controlled by the wallet |
There was a problem hiding this comment.
Suggested change
| // wether the address is controlled by the wallet | |
| // Whether the address is controlled by the wallet. |
a bit flaky with gdk notifications test helper - nothing to worry about in prod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.