feat: migrate CLI to use cobra

[1garo]

Closes #112

[1garo]

@kehoecj

The change seems to be working fine, I mostly was able to reproduce the same thing as Flag.
For sure the code need some trimming and improvements, but I feel that is functional.

If you could do some testing, I could be missing some corn-cases.

Due to some changes the install changed a little bit, as we will still discuss this, I will not change on the README:

CGO_ENABLED=0 \
GOOS=linux \
GOARCH=amd64 \
go build \
-ldflags='-w -s -extldflags "-static"' \
-tags netgo \
-o validator \
main.go

[1garo]

This test case is returning exit status 1 instead of 0:
{"exclude file types set", []string{"--exclude-file-types=json", "."}, 0}

It is because in the "." path there is some "bad files", if I run the same command with the addition of --depth 1 it works fine (folder with just "good files"), what you guys think I could do in this case?

[jd4235]

The lint job failed on the latest pipeline. Need to fix.

[1garo]

The lint job failed on the latest pipeline. Need to fix.

Fixed.

[kehoecj]

A few items:

• We had a few merges prior to this one. Please resolve all conflicts
• During functional checkout I am having issues with generating a valid binary both on MacOS and in the Docker container.

>> docker run -v $(pwd)/test:/test cfv:cobra --depth 0 /test
docker: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/validator": permission denied: unknown.

and macos

>> CGO_ENABLED=0 \
> GOOS=darwin \
> GOARCH=amd64 \
> go build \
> -ldflags='-w -s -extldflags "-static"' \
> -tags netgo \
> -o validator \
> cmd/validator/validator.go
>> ./validator --version
-bash: ./validator: Permission denied

Main does not have this problem so I'm not sure if this is a byproduct of Cobra

[kehoecj]

@1garo Your PR did not properly resolve conflicts in your last update. I started to go through them all but you should get the idea on the rest. It looks like you rejected all upstream conflicts and just kept your code which is now trying to overwrite existing changes

[kehoecj]

@1garo Why was -search_path added back rather than treating it as a positional argument? Search path should remain a positional argument

To clarify, this now fails:

>> docker run -v $(pwd)/test:/test cfv:cobra /test
Error: unknown command "/test" for "validator"
Run 'validator --help' for usage.
unknown command "/test" for "validator"

and instead I have to do this:

docker run -v $(pwd)/test:/test cfv:cobra --search_path /test

[1garo]

@1garo Your PR did not properly resolve conflicts in your last update. I started to go through them all but you should get the idea on the rest. It looks like you rejected all upstream conflicts and just kept your code which is now trying to overwrite existing changes

fixed at 8a5c705

@1garo Why was -search_path added back rather than treating it as a positional argument? Search path should remain a positional argument

To clarify, this now fails:

>> docker run -v $(pwd)/test:/test cfv:cobra /test
Error: unknown command "/test" for "validator"
Run 'validator --help' for usage.
unknown command "/test" for "validator"

and instead I have to do this:

docker run -v $(pwd)/test:/test cfv:cobra --search_path /test

fixed at fix: add search_path as positional argument

[1garo]

You think we should maintain this comment here? Since running -h already outputs the usage?