Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CLI code to use Cobra #112

Open
kehoecj opened this issue Feb 2, 2024 · 3 comments · May be fixed by #114
Open

Refactor CLI code to use Cobra #112

kehoecj opened this issue Feb 2, 2024 · 3 comments · May be fixed by #114
Assignees
@1garo
Labels
CLI Update to the CLI has-pr This issue has an associated PR help wanted Extra attention is needed

Comments

@kehoecj
Copy link
Collaborator

kehoecj commented Feb 2, 2024

This was proposed by the community a while ago but it seems like a good time to refactor our CLI logic from using Flags to COBRA. Cobra offers a lot of functionality such as setting values from environment variables instead of/in addition to command line args, autocompletion, auto generated man pages, etc
@kehoecj kehoecj added help wanted Extra attention is needed CLI Update to the CLI labels Feb 2, 2024
@kehoecj kehoecj changed the title Refactor CLI code to use [Cobra](https://github.com/spf13/cobra) Refactor CLI code to use Cobra Feb 2, 2024
@kehoecj kehoecj mentioned this issue Feb 2, 2024
Closed
@1garo
Copy link

1garo commented Feb 26, 2024

I would like to contribute to this issue!

@kehoecj
Copy link
Collaborator Author

kehoecj commented Feb 26, 2024

I would like to contribute to this issue!

@1garo It's yours!

@1garo
Copy link

1garo commented Feb 27, 2024

@kehoecj working on it!

While reading the readme I came across the build part, have you ever thought about creating a Makefile?
I could do it.

Maybe something like:

$ make mac
$ make mac-install

$ make win
$ make win-install

$ make linux
$ make linux-install

@1garo 1garo linked a pull request Feb 27, 2024 that will close this issue
Open
@kehoecj kehoecj added the has-pr This issue has an associated PR label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1garo 1garo

Labels
CLI Update to the CLI has-pr This issue has an associated PR help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: migrate CLI to use cobra 1garo/config-file-validator
2 participants
@1garo @kehoecj