Fix to issue of exception being thrown for successful transaction #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had issues when capture transaction for an authorized token where the transaction was successful however the `isSuccessfulResponse` returned false. After bunch of logging we found that BluePay API was sending status value as `APPROVED\r`. Because of appended character `\r`, method `isSuccessfulResponse` was returning false.
khantilpatel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had issues in production when capturing transaction for an authorized token the transaction was successful however the
isSuccessfulResponsereturned false. After bunch of logging we found that BluePay API was sending status value asAPPROVED\r. Because of the appended character\r, methodisSuccessfulResponsewas returning false.Note that we were not able to obtain any particular case when BluePay API would send such value, it'd just appear pretty randomly.
So to fix that I've trimmed the status and message values. We've deployed this fix to production and it seem to have fixed our issue. Hope this will help many others who are processing transactions in two steps
Authorize & Capture.